-
Notifications
You must be signed in to change notification settings - Fork 7.6k
lib: uuid: do not support UUID_v5 on TF-M platforms #90372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about instead we would make CONFIG_UUID_V5
depend on !BUILD_WITH_TFM
? It achieves both:
- a clear signal that it won't work when TF-M is enabled;
- and here automatically skipping the problematic test,
test_uuid_v5
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to rework the commit and PR titles/messages
When TF-M is enabled, Mbed TLS's MD module (which is used to generate v5 UUIDs) will dispacth hash operations to TF-M. Unfortunately TF-M does not support SHA-1 (because it's a weak algorithm) so the computation will fail. Signed-off-by: Valerio Setti <[email protected]>
|
When TF-M is enabled, Mbed TLS's MD module (which is used to generate v5 UUIDs) will dispacth hash operations to TF-M. Unfortunately TF-M does not support SHA-1 (because it's a weak algorithm) so the computation will fail.
Resolves #89198