Skip to content

lib: uuid: do not support UUID_v5 on TF-M platforms #90372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

valeriosetti
Copy link
Collaborator

@valeriosetti valeriosetti commented May 23, 2025

When TF-M is enabled, Mbed TLS's MD module (which is used to generate v5 UUIDs) will dispacth hash operations to TF-M. Unfortunately TF-M does not support SHA-1 (because it's a weak algorithm) so the computation will fail.

Resolves #89198

Copy link
Collaborator

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about instead we would make CONFIG_UUID_V5 depend on !BUILD_WITH_TFM? It achieves both:

  • a clear signal that it won't work when TF-M is enabled;
  • and here automatically skipping the problematic test, test_uuid_v5.

Copy link
Collaborator

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to rework the commit and PR titles/messages

@valeriosetti valeriosetti requested a review from tomi-font May 23, 2025 09:06
@valeriosetti valeriosetti changed the title tests: lib: uuid: skip test of UUID_v5 on TF-M platforms lib: uuid: skip test of UUID_v5 on TF-M platforms May 23, 2025
When TF-M is enabled, Mbed TLS's MD module (which is used to generate
v5 UUIDs) will dispacth hash operations to TF-M. Unfortunately TF-M
does not support SHA-1 (because it's a weak algorithm) so the
computation will fail.

Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti valeriosetti changed the title lib: uuid: skip test of UUID_v5 on TF-M platforms lib: uuid: do not support UUID_v5 on TF-M platforms May 23, 2025
@valeriosetti valeriosetti requested a review from ceolin May 23, 2025 09:32
Copy link

@kartben kartben merged commit 31e38c8 into zephyrproject-rtos:main May 27, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lib: uuid: libraries.uuid.base fails
5 participants