drivers: sensor: Remove broken reset from apds9306 driver #90382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
asemjonovs,
avisconti,
jeppenodgaard,
MaureenHelm,
teburd,
tristan-google,
ubieda and
yperess
MaureenHelm
reviewed
May 23, 2025
There was a problem hiding this comment.
Would it work to just ignore the return value of the I2C transaction?
zephyr/drivers/sensor/nxp/fxos8700/fxos8700.c
Lines 554 to 562 in b1f9351
Good idea. Let me test it. |
MaureenHelm
reviewed
May 27, 2025
The reset may cause initialization issues because of a missing ACK from the sensor. The error check for the I2C communication is removed to avoid issues during the initialization. Closes zephyrproject-rtos#89850 Signed-off-by: Daniel Kampert <[email protected]>
|
MaureenHelm
approved these changes
May 28, 2025
nashif
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reset may cause initialization issues because of a missing ACK from the sensor. The error check for the I2C communication is removed to avoid issues during the initialization.
Closes #89850