Skip to content

drivers: rtc: pcf8563: fix get alarm time #90568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

psvtrajan
Copy link
Contributor

While getting alarm time, BIT(7) of each register is checked if it is set, which send the alarm time as 0 to the requestor. Fix it by checking if the BIT(7) of each register is not set.

While getting alarm time, BIT(7) of each register is checked if it is
set, which send the alarm time as 0 to the requestor. Fix it by checking
if the BIT(7) of each register is not set.

Signed-off-by: Thiyagarajan Pandiyan <[email protected]>
@github-actions github-actions bot added the area: RTC Real Time Clock label May 26, 2025
@github-actions github-actions bot requested a review from bjarki-andreasen May 26, 2025 03:26
Copy link

Copy link
Collaborator

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :)

@kartben kartben merged commit f432d5d into zephyrproject-rtos:main May 28, 2025
27 checks passed
Copy link

Hi @psvtrajan!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@psvtrajan psvtrajan deleted the rtc_get_alarm_time branch May 28, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: RTC Real Time Clock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants