drivers: adc_ad4130: Fix out-of-bounds accesses to channel_setup_cfg #90575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: ADC
github-actions
bot
requested review from
galak,
MaureenHelm,
microbuilder,
ozersa,
ttmut and
yasinustunerg
|
cc @oknshn |
Correct the size of the channel_setup_cfg array, as it should contain entries for all available channels (AD4130_MAX_CHANNELS), not for the available configuration slots (AD4130_MAX_SETUPS). Move also checking of the channel index to the very beginning of adc_ad4130_channel_setup(), to avoid potential writes to .live_cfg beyond the channel_setup_cfg array. Signed-off-by: Andrzej Głąbek <[email protected]>
anangl
force-pushed
the
fix_out_of_bounds_reads_ad4130
branch
from
b3ab146 to
f3a1717
Compare
anangl
changed the title
ttmut
approved these changes
May 26, 2025
MaureenHelm
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the size of the channel_setup_cfg array, as it should contain entries for all available channels (AD4130_MAX_CHANNELS), not for the available configuration slots (AD4130_MAX_SETUPS).
Move also checking of the channel index to the very beginning of adc_ad4130_channel_setup(), to avoid potential writes to .live_cfg beyond the channel_setup_cfg array.
Fixes #90507.
Fixes #90514.