Bluetooth: BAP: SD: Add missing error checks for mutex locks #90616
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds error handling for mutex lock operations in the scan delegator after replacing blocking locks with timed locks.
- Replaces
k_mutex_lock(..., K_FOREVER)with timed locks usingSCAN_DELEGATOR_BUF_SEM_TIMEOUTand checks for failures. - Logs failures and returns an error when mutex locking times out in
scan_delegator_add_srcandscan_delegator_mod_src.
Comments suppressed due to low confidence (1)
subsys/bluetooth/audio/bap_scan_delegator.c:767
- [nitpick] Add or extend unit tests to simulate mutex timeouts and verify that
BT_ATT_ERR_INSUFFICIENT_RESOURCESis returned correctly on lock failure.
err = k_mutex_lock(&internal_state->mutex, SCAN_DELEGATOR_BUF_SEM_TIMEOUT);
github-actions
bot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr and
sjanc
Thalley
force-pushed
the
bap_scan_del_fix_mutex_lock
branch
from
16db9cf to
069366e
Compare
Add missing error checks for mutex locks after the mutexes were changed to not use K_FOREVER which should not be done in the BT RX thread. A larger overhaul of how mutexes are using within the scan delegator should be considered, as there are a lot of locks and unlocks when handling the callbacks. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_scan_del_fix_mutex_lock
branch
from
069366e to
30e5438
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing error checks for mutex locks after the mutexes were changed to not use K_FOREVER which should not be done in the BT RX thread.
A larger overhaul of how mutexes are using within the scan delegator should be considered, as there are a lot of locks and unlocks when handling the callbacks.
fixes #90485
fixes #90475