drivers: spi: spi_context.h: remove multithreading dependency #90647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic,
nika-nordic,
tbursztyka and
teburd
teburd
previously requested changes
May 27, 2025
There was a problem hiding this comment.
If you want to do thread-free bus operations, RTIO supports this if the driver supports it with only atomics and lock free queues involved.
At a minimum volatile is the wrong thing here imho. But looking a little further... is this really the right approach to doing thread-free SPI when there's a thread-free option available that does the same thing without the caveats?
nordic-mik7
force-pushed
the
dev/spi_singlethreading_upstream
branch
2 times, most recently
from
9fe55e4 to
1add805
Compare
anangl
reviewed
May 29, 2025
Replace semaphores with proper atomic flags when used without multithreading enabled. Signed-off-by: Michal Kozikowski <[email protected]>
nordic-mik7
force-pushed
the
dev/spi_singlethreading_upstream
branch
from
1add805 to
068afd9
Compare
anangl
approved these changes
May 29, 2025
|
jaz1-nordic
approved these changes
May 30, 2025
|
Ready to be merged. |
The SPI maintainer @tbursztyka (assignee) needs to review and approve before its ready to merge. |
tbursztyka
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace semaphores with proper atomic flags when used without multithreading enabled.