-
Notifications
You must be signed in to change notification settings - Fork 7.6k
tests/c_lib/common/src/test_sqrt: Fix when double is not 64 bits #90650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/c_lib/common/src/test_sqrt: Fix when double is not 64 bits #90650
Conversation
The combination of 3231269 74c9e7a broke this test, when __SIZEOF_DOUBLE__ != 8. In that case the test will fail to build, as the variables the code uses are left ifdef'ed out. Let's fix it. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Fix several code compliance issues. Signed-off-by: Alberto Escolar Piedras <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one typo that could be fixed but not blocking.
5.0, 6.0, 7.0, 8.0, 9.0, /* numbers across the decade */ | ||
3.14159265359, 2.718281828, /* irrational numbers pi and e */ | ||
123.4, 0.025, 0.10, 1.875 /* numbers with infinite */ | ||
/* repeating binary representationa */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* repeating binary representationa */ | |
/* repeating binary representations */ |
13fa0c5
into
zephyrproject-rtos:main
The combination of
3231269
74c9e7a
broke this test, when
__SIZEOF_DOUBLE__ != 8
.In that case the test will fail to build,
as the variables the code uses are left ifdef'ed out.
Let's fix it.
and as a free bonus:
Fix several code compliance issues.