tests/c_lib/common/src/test_sqrt: Fix when double is not 64 bits #90650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combination of 3231269 74c9e7a broke this test, when __SIZEOF_DOUBLE__ != 8. In that case the test will fail to build, as the variables the code uses are left ifdef'ed out. Let's fix it. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Fix several code compliance issues. Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
changed the title
nashif
approved these changes
May 27, 2025
|
keith-packard
approved these changes
May 27, 2025
cfriedt
approved these changes
May 29, 2025
| 5.0, 6.0, 7.0, 8.0, 9.0, /* numbers across the decade */ | ||
| 3.14159265359, 2.718281828, /* irrational numbers pi and e */ | ||
| 123.4, 0.025, 0.10, 1.875 /* numbers with infinite */ | ||
| /* repeating binary representationa */ |
There was a problem hiding this comment.
Suggested change
| /* repeating binary representationa */ | |
| /* repeating binary representations */ |
fabiobaltieri
merged commit 13fa0c5
into
zephyrproject-rtos:main
36 of 38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combination of
3231269
74c9e7a
broke this test, when
__SIZEOF_DOUBLE__ != 8.In that case the test will fail to build,
as the variables the code uses are left ifdef'ed out.
Let's fix it.
and as a free bonus:
Fix several code compliance issues.