i3c: fix coverity discovered issues #90686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dcpleung
commented
May 27, 2025
dcpleung
commented
- i3c: rtio: deal with rtio_cqe_consume() returning NULL
- i3c: set default return for i3c_device_adv_info_get()
This was
linked to
issues
May 27, 2025
|
Twister error is unrelated to this. |
Coverity flagged that the return variable ret may not be initialized when returning. So give it a default value. Fixes zephyrproject-rtos#90509 Signed-off-by: Daniel Leung <[email protected]>
rtio_cqe_consume() may return NULL so we need to check before using any members of the returned struct. Fixes zephyrproject-rtos#90473 Fixes zephyrproject-rtos#90489 Fixes zephyrproject-rtos#90497 Signed-off-by: Daniel Leung <[email protected]>
|
XenuIsWatching
approved these changes
May 28, 2025
pdgendt
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.