drivers: adc: nrfx_saadc: Add support for DMM #90751

jaz1-nordic · 2025-05-28T15:04:16Z

Add support for DMM which manages cache and dedicated memory spaces.

Based on #89469, only the last commit is in scope of this PR.

github-actions · 2025-05-28T15:05:41Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nika-nordic · 2025-06-23T09:54:22Z

drivers/adc/adc_nrfx_saadc.c

+			(void **)&m_data.samples_buffer);
+		if (error != 0) {
+			LOG_ERR("DMM buffer allocation failed err=%d", error);
+			dmm_buffer_in_release(


no need to call in_release if allocation with in_prepare failed.

in_release to be called only after successful in_prepare and input buffer filled by peripheral DMA, indicated by hardware event

nika-nordic · 2025-06-23T09:56:24Z

drivers/adc/adc_nrfx_saadc.c

+				      (void **)&m_data.samples_buffer);
+	if (error != 0) {
+		LOG_ERR("DMM buffer allocation failed err=%d", error);
+		dmm_buffer_in_release(m_data.mem_reg,


not needed - as explained in comment above

nika-nordic · 2025-06-23T10:00:22Z

drivers/adc/adc_nrfx_saadc.c

 		if (has_single_ended(&m_data.ctx.sequence)) {
-			correct_single_ended(&m_data.ctx.sequence);
+			correct_single_ended(&m_data.ctx.sequence, event->data.done.p_buffer);


correct_single_ended should be called on m_data.user_buffer after dma_buffer_in_release call.

User shall not access buffer contents before dmm_buffer_in_release to make sure data cache is correctly handled. Otherwise there is a risk of modifying cached contents and losing them during dmm_buffer_in_release

nika-nordic · 2025-06-23T10:03:45Z

drivers/adc/adc_nrfx_saadc.c

 	uint8_t active_channel_cnt;
-
-#if defined(ADC_BUFFER_IN_RAM)
+	void *mem_reg;
 	void *samples_buffer;


I think holding this pointer in static control block is redundant. This pointer can be obtained as local variable in adc_context_update_buffer_pointer and start_read . Then this pointer is provided to nrfx via nrfx_saadc_buffer_set which provides it back in IRQ context via event->data.done.p_buffer

comment about potential removal of samples_buffer is still valid: https://github.com/zephyrproject-rtos/zephyr/pull/90751/files#r2161217660

Add support for DMM which manages cache and dedicated memory spaces. Signed-off-by: Jakub Zymelka <[email protected]>

sonarqubecloud · 2025-07-03T08:52:35Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nika-nordic · 2025-07-03T17:45:27Z

drivers/adc/adc_nrfx_saadc.c

 		if (has_single_ended(&m_data.ctx.sequence)) {
-			correct_single_ended(&m_data.ctx.sequence);
+			correct_single_ended(&m_data.ctx.sequence, m_data.user_buffer);


buffer managed by dmm cannot be accessed before dmm_buffer_in_release - should be moved after dmm_buffer_in_release

nika-nordic · 2025-07-03T17:47:03Z

drivers/adc/adc_nrfx_saadc.c

 	uint8_t active_channel_cnt;
-
-#if defined(ADC_BUFFER_IN_RAM)
+	void *mem_reg;
 	void *samples_buffer;


comment about potential removal of samples_buffer is still valid: https://github.com/zephyrproject-rtos/zephyr/pull/90751/files#r2161217660

nika-nordic · 2025-07-03T17:48:49Z

drivers/adc/adc_nrfx_saadc.c

 };

 static struct driver_data m_data = {
 	ADC_CONTEXT_INIT_TIMER(m_data, ctx),
 	ADC_CONTEXT_INIT_LOCK(m_data, ctx),
 	ADC_CONTEXT_INIT_SYNC(m_data, ctx),
-#if defined(ADC_BUFFER_IN_RAM)
-	.samples_buffer = adc_samples_buffer,
+#if defined(CONFIG_HAS_NORDIC_DMM)


this conditional is redundant - DMM_DEV_TO_REG will return NULL if there is no memory-region prop present

nika-nordic · 2025-07-03T17:50:11Z

drivers/adc/adc_nrfx_saadc.c

+			LOG_ERR("DMM buffer allocation failed err=%d", error);
+			adc_context_complete(ctx, -EIO);
+		}
+#if !defined(CONFIG_HAS_NORDIC_DMM)


I believe this is spurious and will cause missing buffer update on H20 in case of sequence composed of several samplings

jaz1-nordic requested review from nordic-krch, nika-nordic, masz-nordic and magp-nordic May 28, 2025 15:04

github-actions bot added platform: nRF Nordic nRFx area: Samples Samples area: ADC Analog-to-Digital Converter (ADC) labels May 28, 2025

github-actions bot requested review from anangl, kartben, kl-cruz and nashif May 28, 2025 15:05

github-actions bot assigned anangl May 28, 2025

github-actions bot added manifest manifest-hal_nordic DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 28, 2025

jaz1-nordic force-pushed the nrfx-7601_saadc_dmm_support branch 4 times, most recently from a622b40 to faa7caf Compare June 4, 2025 13:06

jaz1-nordic force-pushed the nrfx-7601_saadc_dmm_support branch from faa7caf to 43b7d0b Compare June 9, 2025 12:56

github-actions bot removed manifest manifest-hal_nordic DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jun 9, 2025

kl-cruz previously approved these changes Jun 12, 2025

View reviewed changes

jaz1-nordic dismissed kl-cruz’s stale review via 6a5a5c3 June 16, 2025 13:36

jaz1-nordic force-pushed the nrfx-7601_saadc_dmm_support branch from 43b7d0b to 6a5a5c3 Compare June 16, 2025 13:36

github-actions bot requested a review from hubertmis June 16, 2025 13:37

jaz1-nordic force-pushed the nrfx-7601_saadc_dmm_support branch 2 times, most recently from 8732416 to d519bd8 Compare June 17, 2025 09:44

jaz1-nordic force-pushed the nrfx-7601_saadc_dmm_support branch 2 times, most recently from d2e83b2 to 76b5fc3 Compare June 18, 2025 11:50

masz-nordic force-pushed the nrfx-7601_saadc_dmm_support branch from 76b5fc3 to 9cb6a97 Compare June 18, 2025 13:35

masz-nordic requested a review from kl-cruz June 23, 2025 09:48

nika-nordic reviewed Jun 23, 2025

View reviewed changes

drivers: adc: nrfx_saadc: Add support for DMM

7740772

Add support for DMM which manages cache and dedicated memory spaces. Signed-off-by: Jakub Zymelka <[email protected]>

masz-nordic force-pushed the nrfx-7601_saadc_dmm_support branch from 9cb6a97 to 7740772 Compare July 3, 2025 08:26

masz-nordic requested a review from nika-nordic July 3, 2025 08:26

nika-nordic reviewed Jul 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

drivers: adc: nrfx_saadc: Add support for DMM #90751

drivers: adc: nrfx_saadc: Add support for DMM #90751

jaz1-nordic commented May 28, 2025

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading

Uh oh!

nika-nordic Jun 23, 2025

Uh oh!

nika-nordic Jun 23, 2025

Uh oh!

nika-nordic Jun 23, 2025

Uh oh!

nika-nordic Jun 23, 2025

Uh oh!

nika-nordic Jul 3, 2025

Uh oh!

sonarqubecloud bot commented Jul 3, 2025

Uh oh!

nika-nordic Jul 3, 2025

Uh oh!

nika-nordic Jul 3, 2025

Uh oh!

nika-nordic Jul 3, 2025

Uh oh!

nika-nordic Jul 3, 2025

Uh oh!

Uh oh!

drivers: adc: nrfx_saadc: Add support for DMM #90751

Are you sure you want to change the base?

drivers: adc: nrfx_saadc: Add support for DMM #90751

Conversation

jaz1-nordic commented May 28, 2025

Uh oh!

github-actions bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jul 3, 2025

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading