west: spdx: allow to generate for different SPDX versions #90753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartben
force-pushed
the
zpdx_22_23
branch
4 times, most recently
from
2f73b5d to
5caf163
Compare
github-actions
bot
requested review from
carlescufi,
nashif,
pdgendt and
swinslow
|
Could we try to get #90444 merged first? |
kartben
force-pushed
the
zpdx_22_23
branch
2 times, most recently
from
c91542b to
4a3a19e
Compare
I just rebased on main :) |
pdgendt
previously approved these changes
Jun 3, 2025
As reported by sonarqube, "String formatting should be used correctly" Signed-off-by: Benjamin Cabé <[email protected]>
File passes all ruff linter checks so no exclude rules needed anymore Signed-off-by: Benjamin Cabé <[email protected]>
Add missing error handling of some of the calls to writeSPDX(). Signed-off-by: Benjamin Cabé <[email protected]>
When support for SPDX 2.3 was added, it effectively dropped support for SPDX 2.2, which in retrospect was a bad idea since SPDX 2.2 is the version that is the current ISO/IEC standard. This commit adds a `--spdx-version` option to the `west spdx` command so that users can generate SPDX 2.2 documents if they want. Default is 2.3 given that's effectively what shipped for a few releases now, including latest LTS. Signed-off-by: Benjamin Cabé <[email protected]>
pdgendt
approved these changes
Jun 3, 2025
|
|
@swinslow @carlescufi can you please have a look? Thanks! |
carlescufi
reviewed
Jun 10, 2025
Comment on lines
+57
to
+63
| self.dbg(" --init is", args.init) | ||
| self.dbg(" --build-dir is", args.build_dir) | ||
| self.dbg(" --namespace-prefix is", args.namespace_prefix) | ||
| self.dbg(" --spdx-dir is", args.spdx_dir) | ||
| self.dbg(" --spdx-version is", args.spdx_version) | ||
| self.dbg(" --analyze-includes is", args.analyze_includes) | ||
| self.dbg(" --include-sdk is", args.include_sdk) |
There was a problem hiding this comment.
You could've used the f-strings here:
self.dbg(" --init is {args.init}")
carlescufi
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When support for SPDX 2.3 was added, it effectively dropped support for SPDX 2.2, which in retrospect was a bad idea since SPDX 2.2 is the version that is the current ISO/IEC standard.
This commit adds a
--spdx-versionoption to thewest spdxcommand so that users can generate SPDX 2.2 documents if they want.Default is 2.3 given that's effectively what shipped for a few releases now, including latest LTS, but it could be argued it should be 2.2 as per my comment above re: it being the ISO standard.