boards: raspberrypi: rpi_pico: Use sysbuild.overlay

[jlbwoods]

Use boards/raspberrypi/rpi_pico/sysbuild.overlay for rpi_pcio to build
SysBuild images.

[soburi]

#90758 (comment)

#90758 (comment)

There are no other issues besides this one from me.

I will approve it as soon as it is fixed.

[jlbwoods]

What's the next step to get this merged?

[soburi]

@nordicjm
Can you take a look again please?

[soburi]

@jlbwoods

I don't think no need to make sysbuild as default, is there a reason for the change?

[jlbwoods]

@jlbwoods

I don't think no need to make sysbuild as default, is there a reason for the change?

The reason to make sysbuild as default is because most of the overlays inside mcuboot/boot/zephyr/boards are using sysbuild partition layouts. The sysbuild partitions are "default" with samples like zephyr/samples/sysbuild/with_mcuboot/ since it is assuming sysbuild type partitions and thus there is no boards folder in the sample.

[soburi]

@jlbwoods
I don't think no need to make sysbuild as default, is there a reason for the change?

The reason to make sysbuild as default is because most of the overlays inside mcuboot/boot/zephyr/boards are using sysbuild partition layouts. The sysbuild partitions are "default" with samples like zephyr/samples/sysbuild/with_mcuboot/ since it is assuming sysbuild type partitions and thus there is no boards folder in the sample.

Currently, sysbuild is not the default for SoCs other than those that require different images for two CPUs, such as the ESP32 and NRF91.
For passing tests, we only require adding overlay files.
Therefore, I believe this change requires a justification based on the use case.

The sysbuild configuration is meaningful if enabled mcuboot, but the RP2350 does not have a reason to make it the default.
(The default must keep simple.)
Without it, the change only reduces the user's usable storage.

I don't believe it is necessary to apply sysbuild as the default for the RP2350, as is the case with most other SoCs.

[jlbwoods]

@jlbwoods
I don't think no need to make sysbuild as default, is there a reason for the change?

The reason to make sysbuild as default is because most of the overlays inside mcuboot/boot/zephyr/boards are using sysbuild partition layouts. The sysbuild partitions are "default" with samples like zephyr/samples/sysbuild/with_mcuboot/ since it is assuming sysbuild type partitions and thus there is no boards folder in the sample.

Currently, sysbuild is not the default for SoCs other than those that require different images for two CPUs, such as the ESP32 and NRF91. For passing tests, we only require adding overlay files. Therefore, I believe this change requires a justification based on the use case.

The sysbuild configuration is meaningful if enabled mcuboot, but the RP2350 does not have a reason to make it the default. (The default must keep simple.) Without it, the change only reduces the user's usable storage.

I don't believe it is necessary to apply sysbuild as the default for the RP2350, as is the case with most other SoCs.

Thank you for the detailed explanation. Everything make sense now!

I will close this PR and leave the default partitions in place.

[jlbwoods]

Reopening the PR to try out raspberrypi/rpi_pico/sysbuild.overlay way:
zephyrproject-rtos/mcuboot#129

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarQube Cloud

[jlbwoods]

sysbuild.overlay is not yet implemented.