-
Notifications
You must be signed in to change notification settings - Fork 7.4k
drivers: adc: add dma support for ambiq adc driver #90776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4c70e15
to
695e241
Compare
695e241
to
404cb8e
Compare
404cb8e
to
b51c9a0
Compare
b51c9a0
to
35bebe3
Compare
2487477
to
2ab118c
Compare
This commit adds dma support for ambiq adc driver Signed-off-by: Hao Luo <[email protected]>
2ab118c
to
efbfc63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds DMA support to the Ambiq ADC driver. The changes include updating device tree overlays and YAML bindings to add new DMA properties, modifying the ADC driver implementation to support DMA transfers (including added DMA configuration, triggering, and completion handling), and updating related DTS and Kconfig files.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
samples/drivers/adc/adc_dt/boards/apollo510_evb.overlay | Adjusted ADC channel indexes and added DMA-related properties |
samples/drivers/adc/adc_dt/boards/apollo3_evb.overlay | Enabled DMA mode by adding dma-mode in the overlay |
dts/bindings/adc/ambiq,adc.yaml | Introduced new DMA property definitions for dma-mode, dma-buffer-location, and dma-buffer-size |
dts/arm/ambiq/*.dtsi | Removed unused counter nodes |
drivers/adc/adc_ambiq.c | Added DMA configuration, updated buffer types, integrated semaphore for DMA completion, and refactored ADC initialization and ISR |
drivers/adc/Kconfig.ambiq | Updated configuration to conditionally select timer and cache handling options |
boards//.dts | Minor adjustments in pinmux and counter configurations |
Comments suppressed due to low confidence (1)
drivers/adc/adc_ambiq.c:45
- [nitpick] Ensure that changing the buffer pointer type from uint16_t to uint32_t is consistently handled in all DMA data processing and that any dependent calculations or type conversions are updated accordingly.
uint16_t *buffer; // changed to uint32_t *buffer;
|
This commit adds dma support for ambiq adc driver