-
Notifications
You must be signed in to change notification settings - Fork 7.6k
drivers: misc: ethos_u: Create the ethos_u_common for every vendor #90787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: misc: ethos_u: Create the ethos_u_common for every vendor #90787
Conversation
1a08f90
to
2b277d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can support other vendor's ethos-u npu.
Could you provide more details on what the custom procedures are? maybe this is something that can be done in one of the CONFIG_SOC_*_HOOK |
From our Renesas MCU side, we need to clear the HW frag when the interrupt is raised, and it definitely can't be cleared in the Therefore, I propose this PR to clarify the init function and allow modifying the handler to clear the NPU flag for each vendor, rather than simply covering it within |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It helps for other vendors to add their ethos-u driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I understand the reason for the change. Added a few comments to see if we can have a cleaner solution for this.
@khoa-nguyen-18 just a reminder that the feature freeze for 4.2 is rapidly approaching (end of the week) and if this is needed in for 4.2 you'll need to get the reviews from the maintainers. |
2b277d2
to
a5be8fb
Compare
Try to rebase #88941 on this reorg, and that's fine. |
- Update to use ETHOS_U config instead of ARM_ETHOS_U - Update prefix ETHOS_U_ for all configs that use ARM_ETHOS_U_ Signed-off-by: Khoa Nguyen <[email protected]>
a5be8fb
to
b4f316d
Compare
Seperate the ``ethos_u_common`` for every vendor and ``ethos_u_arm`` for sepcific Arm's boards. Enable vendors to self-configure the init flow and IRQ handler. Signed-off-by: Khoa Nguyen <[email protected]>
Update Ethos-U driver config for sample app `tflm_ethosu` Signed-off-by: Khoa Nguyen <[email protected]>
b4f316d
to
f10211d
Compare
|
Some vendors require custom procedures to be executed before and after calling the
ethosu_init
andethosu_irq_handler
APIs from the Ethos-U core driver.As a solution, I propose separating
ethos_u_common
for each vendor andethos_u_arm
for specific Arm boards, enabling vendors to self-configure the initialization flow and IRQ handler.Building sample
samples/modules/tflite-micro/tflm_ethosu
log: