Skip to content

modules: hal_nordic: nrf_802154: CCA threshold config in dBm + nRF54L15 clock latency #90795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025

Conversation

e-rk
Copy link
Collaborator

@e-rk e-rk commented May 29, 2025

The nrf-802154 component of hal_nordic is updated. The CCA threshold configuration is now done in dBm units, instead of hardware-dependent scale.
Fixed a bug, where the CONFIG_NRF_802154_CCA_ED_THRESHOLD units were different from the NRF_802154_CCA_ED_THRESHOLD units. Now all configuration is done in dBm.

Addidtionally, added clock latency configuration and a more optimized HFXO startup time for nRF54L15 DK.

Copy link

github-actions bot commented May 29, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_nordic DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 29, 2025
@e-rk e-rk force-pushed the update-nrf-802154 branch from ece1288 to 592cb16 Compare May 29, 2025 09:36
ankuns
ankuns previously approved these changes May 29, 2025
@e-rk e-rk force-pushed the update-nrf-802154 branch from 592cb16 to 3fda372 Compare June 10, 2025 13:44
@e-rk e-rk changed the title modules: hal_nordic: nrf_802154: CCA threshold config in dBm modules: hal_nordic: nrf_802154: CCA threshold config in dBm + nRF54L15 clock latency Jun 10, 2025
@@ -18,7 +18,11 @@ static bool hfclk_is_running;

void nrf_802154_clock_init(void)
{
/* Intentionally empty. */
#ifdef NRF54L_SERIES
uint32_t clock_latency_us = z_nrf_clock_bt_ctlr_hf_get_startup_time_us();
Copy link
Collaborator

@ankuns ankuns Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just curious. Is there a reason to not do

#if DT_NODE_EXISTS(DT_NODELABEL(hfxo))
    uint32_t clock_latency_us = DT_PROP(DT_NODELABEL(hfxo), startup_time_us);
    nrf_802154_clock_hfclk_latency_set(clock_latency_us);
#endif

?

If you prefer to call z_nrf_clock_bt_ctlr_hf_get_startup_time_us, note it is wrapped with
#if DT_NODE_EXISTS(DT_NODELABEL(hfxo))
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/clock_control/clock_control_nrf.c#L440

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property is marked as required on nordic,nrf54l-hfxo binding. If there is no such property, the build will fail due to missing property.

ankuns
ankuns previously approved these changes Jun 11, 2025
anangl
anangl previously approved these changes Jun 18, 2025
ankuns
ankuns previously approved these changes Jun 18, 2025
@e-rk e-rk dismissed stale reviews from ankuns and anangl via c58c6dd June 18, 2025 08:49
@e-rk e-rk force-pushed the update-nrf-802154 branch from 8c8b5b6 to c58c6dd Compare June 18, 2025 08:49
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Jun 18, 2025
anangl
anangl previously approved these changes Jun 18, 2025
ankuns
ankuns previously approved these changes Jun 18, 2025
@e-rk
Copy link
Collaborator Author

e-rk commented Jun 26, 2025

Blocked by: #92009

e-rk added 3 commits June 26, 2025 12:51
The nrf-802154 component of hal_nordic is updated.
The CCA threshold configuration is now done in dBm units, instead of
hardware-dependent scale.
Fixed a bug, where the CONFIG_NRF_802154_CCA_ED_THRESHOLD units were
different from the NRF_802154_CCA_ED_THRESHOLD units. Now all
configuration is done in dBm.

Signed-off-by: Rafał Kuźnia <[email protected]>
The HFXO used on nRF54L15 DK has the typical startup latency of 854us.

Signed-off-by: Rafał Kuźnia <[email protected]>
The clock startup latency is now obtained from the clock driver and the
nrf-802154 is now set to a value that matches hardware capabilities.

Signed-off-by: Rafał Kuźnia <[email protected]>
Copy link

@e-rk
Copy link
Collaborator Author

e-rk commented Jun 26, 2025

Rebased after the littlefs twister test fix was merged to main.

@e-rk
Copy link
Collaborator Author

e-rk commented Jun 26, 2025

CI green. @anangl @ankuns could you re-review?

@danieldegrasse danieldegrasse merged commit 558f26e into zephyrproject-rtos:main Jun 26, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: nRF Nordic nRFx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants