You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is to fix spi_context.h .
The unit of spi_context's tx_len and rx_len is byte instead of frame.
The value of ctx->tx_len should be reduced by (len * dfs).
The unit of spi_context's tx_len and rx_len is byte instead of frame.
Thus, in spi_context_update_tx(), the value of ctx->tx_len should be
reduced by (len * dfs).
Also to fix the update of ctx->tx_len in spi_context_update_rx().
Signed-off-by: cyliang tw <[email protected]>
this PR should have been raised to awareness of more people, I had no idea about it and although the change looks small and sounds right, it has seriously huge implications, see #91075 . Maybe the change is correct, I'll need to check, at first glance it seems correct , but I seriously doubt that this doesn't have huge effects on every spi driver that uses the spi context . All the drivers should have been updated to reflect this change in behavior to the shared code
I tried to give the PR the benefit of the doubt, but now I looked through closely the spi_context file and debugged the new behavior and can say now that I have no idea how this PR even got submitted, let alone approved and merged, it's totally incorrect
I tried to give the PR the benefit of the doubt, but now I looked through closely the spi_context file and debugged the new behavior and can say now that I have no idea how this PR even got submitted, let alone approved and merged, it's totally incorrect
Can you or someone else please send a revert if it's that badly broken? Thanks!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix spi_context.h .
The unit of spi_context's tx_len and rx_len is byte instead of frame.
The value of ctx->tx_len should be reduced by (len * dfs).