-
Notifications
You must be signed in to change notification settings - Fork 7.6k
boards: m5stack: add support for M5Stack Fire #90799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @novakjak, and thank you very much for your first pull request to the Zephyr project! |
09212a2
to
a6d0a14
Compare
Thanks for the reviews. I haven't responded to them directly but they've been addressed and helpful in forcing me to triple check things. |
Adds support for the M5Stack Fire. Board files are adapted from those used for the M5Stack Core2. Aside from the 2 newest revisions the device also contains a BMM150 magnetometer which is not supported. The LED strips on the sides are also not supported because Zephyr does not support fast GPIO switching, see: zephyrproject-rtos#11917. The IP5306 charger works by itself but doesn't have a driver written for it thus it's not able to be interfaced with. Signed-off-by: Jakub Novák <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks @novakjak 👍
It would be good to get review from @sylvioalves too for the esp32 specifics, and also from @kartben for docs.
Thanks @novakjak! |
Hi @novakjak! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
Adds support for the M5Stack Fire. Board files are adapted from those used for the M5Stack Core2.
Aside from the 2 newest revisions the device also contains a BMM150 magnetometer which is not supported.
The LED strips on the sides are also not supported because Zephyr does not support fast GPIO switching, see: #11917.
The IP5306 charger works by itself but doesn't have a driver written for it thus it's not able to be interfaced with.