Skip to content

boards: m5stack: add support for M5Stack Fire #90799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

novakjak
Copy link

Adds support for the M5Stack Fire. Board files are adapted from those used for the M5Stack Core2.

Aside from the 2 newest revisions the device also contains a BMM150 magnetometer which is not supported.
The LED strips on the sides are also not supported because Zephyr does not support fast GPIO switching, see: #11917.
The IP5306 charger works by itself but doesn't have a driver written for it thus it's not able to be interfaced with.

Copy link

Hello @novakjak, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@nordicjm nordicjm requested a review from kartben May 29, 2025 11:53
@novakjak novakjak requested a review from nordicjm May 29, 2025 12:30
@novakjak novakjak force-pushed the m5stack_fire branch 4 times, most recently from 09212a2 to a6d0a14 Compare May 30, 2025 07:30
@novakjak
Copy link
Author

novakjak commented May 30, 2025

Thanks for the reviews. I haven't responded to them directly but they've been addressed and helpful in forcing me to triple check things.

Adds support for the M5Stack Fire. Board files are adapted from those
used for the M5Stack Core2.

Aside from the 2 newest revisions the device also contains a BMM150
magnetometer which is not supported.

The LED strips on the sides are also not supported because Zephyr
does not support fast GPIO switching, see: zephyrproject-rtos#11917.

The IP5306 charger works by itself but doesn't have a driver written for
it thus it's not able to be interfaced with.

Signed-off-by: Jakub Novák <[email protected]>
Copy link

Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks @novakjak 👍
It would be good to get review from @sylvioalves too for the esp32 specifics, and also from @kartben for docs.

@kartben
Copy link
Collaborator

kartben commented Jun 4, 2025

Thanks @novakjak!

@kartben kartben merged commit 342c737 into zephyrproject-rtos:main Jun 4, 2025
21 checks passed
Copy link

github-actions bot commented Jun 4, 2025

Hi @novakjak!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants