kernel: dynamic: Dynamic userspace stacks improvements #90803
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarecki
requested review from
lyakh,
lgirdwood,
abonislawski,
kv2019i,
marcinszkudlinski,
jxstelter,
tmleman and
serhiy-katsyuba-intel
github-actions
bot
requested review from
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre and
peter-mitsis
|
@softwarecki - can you please rebase? |
|
peter-mitsis
previously approved these changes
Jun 5, 2025
|
I should have checked out the failing checks first before hitting approve. |
Add the flags parameter to the z_thread_stack_alloc_pool function. Determine the maximum possible stack size based on the size of the reserved memory for stack and the thread type (flags). The stack size that can be used by a thread depend on its type (kerner/user). For the same stack size, the macros K_KERNEL_STACK_DECLARE and K_THREAD_STACK_DEFINE may reserve different amount of memory. Signed-off-by: Adrian Warecki <[email protected]>
|
cfriedt
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize stack pool usage by add the
flagsparameter to thez_thread_stack_alloc_poolfunction and determine the maximum possible stack size based on the size of the reserved memory for stack and the thread type (flags).The stack size that can be used by a thread depend on its type (kerner/user). For the same stack size, the macros
K_KERNEL_STACK_DECLAREandK_THREAD_STACK_DEFINEmay reserve different amount of memory. The actual memory required by the user thread stack may be larger than the user-specified size, as it can include additional reserved space.Fix dynamic user stack allocation by use the
K_THREAD_STACK_LENmacro to determine the size of the memory that need to by allocated for the user stack.