PR metadata check: few tweaks and wait for the Manifest workflow explicitly #90806
Conversation
Log the PR link and labels, may come in handy for troubleshooting down the road. Signed-off-by: Fabio Baltieri <[email protected]>
fabiobaltieri
force-pushed
the
do-not-merge-wait
branch
from
482f419 to
f3cc738
Compare
fabiobaltieri
added
DNM
fabiobaltieri
force-pushed
the
do-not-merge-wait
branch
from
f3cc738 to
d1f32fc
Compare
fabiobaltieri
removed
DNM
|
This should take care of the #90800 problem. And probably introduce another dozen new ones. |
No point spreading the logic around, the python file already has the data, check it there. Signed-off-by: Fabio Baltieri <[email protected]>
Seems like github relabel rerun is susceptible to race conditions and may not rerun the label check script if the manifest workflow runs at the same time. Delay the check to explicitly wait until the currently checked sha had a successful manifest run. Signed-off-by: Fabio Baltieri <[email protected]>
Makes it easier to debug since there's stuff handling race conditions now. Signed-off-by: Fabio Baltieri <[email protected]>
fabiobaltieri
force-pushed
the
do-not-merge-wait
branch
from
d1f32fc to
3e4db58
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
|
This does feel fragile, no? Can't we use the GH action dependency mechanism for that? Also won't this do more GH API calls, which we tried to prevent before? |
With What specifically do you find fragile about it? At least when it'll go wrong I can log stuff and figure what happened. As for the API calls, I think that ship has sailed. Or rather that kite has flown. |
fabiobaltieri
added
area: Input
Couple improvements to the python script for pr metadata check, mainly add an explicit wait for the manifest run, hopefully it'll fix the current race condition for good.