include: dt-bindings: fix and extend the ch32v00x pinctrl definitions #90814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll wait on #90243 which has a similar update for SPI. |
VynDragon
previously approved these changes
May 29, 2025
miggazElquez
approved these changes
May 30, 2025
|
I noticed a few issues with the PR - there were duplicate blocks due to the CH32V007 vs all other CH32V00x, and bugs in the I2C and SPI references. I'll patch in #90690 and manually run Twister. |
|
|
VynDragon
previously approved these changes
May 30, 2025
miggazElquez
approved these changes
Jun 9, 2025
kartben
requested changes
Jun 9, 2025
| #define I2C1_SDA_PC1_0 CH32V00X_PINMUX_DEFINE(PC, 1, I2C1, 0) | ||
| #define I2C1_SDA_PD0_1 CH32V00X_PINMUX_DEFINE(PD, 0, I2C1, 1) | ||
| #define I2C1_SDA_PC6_2 CH32V00X_PINMUX_DEFINE(PC, 6, I2C1, 2) | ||
| /* CH32V007 specific remap */ | ||
| #define I2C1_SDA_PC4_2 CH32V00X_PINMUX_DEFINE(PC, 4, I2C, 2) |
There was a problem hiding this comment.
Suggested change
| #define I2C1_SDA_PC4_2 CH32V00X_PINMUX_DEFINE(PC, 4, I2C, 2) | |
| #define I2C1_SDA_PC4_2 CH32V00X_PINMUX_DEFINE(PC, 4, I2C1, 2) |
There was a problem hiding this comment.
Good catch, done.
nzmichaelh
force-pushed
the
fix-pinctrl
branch
2 times, most recently
from
342e22f to
cbef71c
Compare
These were wrong and incomplete. Rebuild based on section 7.2.11 of the CH32V00XRM and added the CH32V007-only remaps. Signed-off-by: Michael Hope <[email protected]>
kartben
approved these changes
Jun 25, 2025
|
VynDragon
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were wrong and incomplete. Rebuild based on section 7.2.11 of the CH32V00XRM.