-
Notifications
You must be signed in to change notification settings - Fork 7.4k
drivers: counter: fix counter node in esp32 timers #90819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: counter: fix counter node in esp32 timers #90819
Conversation
16344b6
to
d191644
Compare
Ok, as you provided the fix here, I guess we don't need to revert it. The only diff is the updated overlays? Regarding your comment about the 4s alarm issue, the fix is here #90817 |
As you prefer. Yes, the overlay and also the #define TIMER in the main.c of the sample. |
Sure, update it with the new diff only. I'll run in internal CI to make sure it is all working as well. Thanks for fixing it. |
d191644
to
0a58e5e
Compare
Done, ready for review. And sorry for disturbance. |
No disturbance at all. Would you mind adding |
Fix counter device tree node of the esp32 timers in the counter sample and test app. Signed-off-by: Joel Guittet <[email protected]>
0a58e5e
to
5f0ef01
Compare
Sure. Added. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fully tested, all working.
Fix counter device tree node to the esp32 timers.
@sylvioalves I have tested
samples/drivers/counter/alarm
:(the 4 seconds alarm is not working but it was also the case before my modification, so it's not a regression).
And
tests/drivers/counter/counter_basic_api
:But of course if you can get your feedback on the modifications I will appreciate, or even if you can run in your pipelines ?