drivers: dma_mcux_lpc: fix bug using INPUTMUX #90830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typical way of calling INPUTMUX_AttachSignal() is to bracket it around INPUTMUX_Init() and INPUTMUX_Deinit() calls because we can reduce power consumption by not keeping the interface powered when not changing INPUTMUX. This driver was violating that convention, which caused it to not coexist well with other code that followed the usage convention because the INPUTMUX might be initialized or not depending on execution order with the other modules. Signed-off-by: Mike J. Chen <[email protected]>
github-actions
bot
added
platform: NXP Drivers
github-actions
bot
requested review from
dbaluta,
decsny,
dleach02,
manuargue,
mmahadevan108,
Raymond0225 and
teburd
|
dleach02
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typical way of calling INPUTMUX_AttachSignal() is to bracket it around INPUTMUX_Init() and INPUTMUX_Deinit() calls because we can reduce power consumption by not keeping the interface powered when not changing INPUTMUX.
This driver was violating that convention, which caused it to not coexist well with other code that followed the usage convention because the INPUTMUX might be initialized or not depending on execution order with the other modules.