drivers: flash: jesd216: improve mode support checks #90857
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the failed checks are unrelated it seems |
anangl
previously approved these changes
Jun 4, 2025
The only information for 4s-4d-4d, 8s-8s-8s and 8d-8d-8d in the basic flash parameter table is in DWORD20 with one byte for each of the aforementioned modes. This one byte is split into two fields that contain that mode's maximum operation speed with and without data strobe. Unsupported fields have the value of 0xF. For the mode to be supported, at least one of the two fields must not be 0xF, so we check the byte against 0xFF. Signed-off-by: Amneesh Singh <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only information for 4s-4d-4d, 8s-8s-8s and 8d-8d-8d in the basic flash parameter table is in DWORD20 with one byte for each of the aforementioned modes. This one byte is split into two fields that contain that mode's maximum operation speed with and without data strobe. Unsupported fields have the value of 0xF. For the mode to be supported, at least one of the two fields must not be 0xF, so we check the byte against 0xFF.