drivers: wifi: siwx91x: Handling data packets for AP mode #90860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
asmellby,
jerome-pouiller,
jhedberg,
jukkar,
Kludentwo,
krish2718,
MaochenWang1,
Martinhoff-maker and
rlubos
ragurram26
force-pushed
the
ap_mode_data
branch
2 times, most recently
from
43b38b3 to
2391922
Compare
drivers/wifi/siwx91x/siwx91x_wifi.c
Outdated
| @@ -1336,6 +1336,8 @@ static int siwx91x_send(const struct device *dev, struct net_pkt *pkt) | |||
| size_t pkt_len = net_pkt_get_len(pkt); | |||
| struct net_buf *buf = NULL; | |||
| int ret; | |||
| sl_wifi_operation_mode_t opermode; | |||
| sl_wifi_interface_t interface = SL_WIFI_CLIENT_INTERFACE; | |||
There was a problem hiding this comment.
Use inverse Christmas tree order wherever possible
drivers/wifi/siwx91x/siwx91x_wifi.c
Outdated
| } else if (opermode == SL_SI91X_ACCESS_POINT_MODE) { | ||
| interface = SL_WIFI_AP_INTERFACE; | ||
| } | ||
| ret = sl_wifi_send_raw_data_frame(interface, buf->data, pkt_len); |
There was a problem hiding this comment.
sl_wifi_interface_t interface = sl_wifi_get_default_interface(); sl_wifi_send_raw_data_frame(FIELD_GET(SIWX91X_INTERFACE_MASK, interface), buf->data, pkt_len);
I suggest using this approach to maintain consistency in interface handling
ragurram26
force-pushed
the
ap_mode_data
branch
3 times, most recently
from
e1f8a48 to
7c2a545
Compare
asmellby
previously approved these changes
Jun 4, 2025
jerome-pouiller
previously approved these changes
Jun 4, 2025
drivers/wifi/siwx91x/siwx91x_wifi.c
Outdated
| ret = sl_wifi_send_raw_data_frame(SL_WIFI_CLIENT_INTERFACE, buf->data, pkt_len); | ||
| interface = sl_wifi_get_default_interface(); | ||
| ret = sl_wifi_send_raw_data_frame( | ||
| FIELD_GET(SIWX91X_INTERFACE_MASK, interface), buf->data, pkt_len); |
There was a problem hiding this comment.
Nitpick: the prefered place to split a line is between the arguments:
ret = sl_wifi_send_raw_data_frame(FIELD_GET(SIWX91X_INTERFACE_MASK, interface),
buf->data, pkt_len);
In the raw data send API, the interface was hardcoded for client mode. Now, we determine the opermode and pass the appropriate interface to the raw data API based on the current opermode. Signed-off-by: Rahul Gurram <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
jerome-pouiller
approved these changes
Jun 4, 2025
asmellby
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the raw data send API, the interface was hardcoded for client mode. Now, we determine the opermode and pass the appropriate interface to the raw data API based on the current opermode.