boards: nordic: add runner config qualifiers for 54h20 'iron' variants #90868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
nordicjm
requested changes
Jun 4, 2025
soc/nordic/soc.yml
Outdated
| @@ -126,7 +126,9 @@ runners: | |||
| - nrf54l20/cpuflpr | |||
| - qualifiers: | |||
| - nrf54h20/cpuapp | |||
| - nrf54h20/cpuapp/iron | |||
There was a problem hiding this comment.
board qualifiers are not allowed in a soc file, put it in the board.yml file
There was a problem hiding this comment.
@jonathannilsen it can be done similar like for L15:
https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/nordic/nrf54l15dk/board.yml#L17
jonathannilsen
force-pushed
the
iron-flashing-fix
branch
from
8d3eb65 to
d1b4d55
Compare
jonathannilsen
changed the title
nordicjm
reviewed
Jun 4, 2025
boards/nordic/nrf54h20dk/board.yml
Outdated
| run: first | ||
| groups: | ||
| - boards: | ||
| - [email protected]/nrf54h20/cpuapp/iron |
There was a problem hiding this comment.
you will need to add the other ones from the base soc.yml file or they will vanish because of this
There was a problem hiding this comment.
I see, do they need to be added both with and without the 0.9.0 revision as well?
jonathannilsen
force-pushed
the
iron-flashing-fix
branch
from
d1b4d55 to
1493417
Compare
Make it so the 54h20 'iron' variants have the same flashing behavior as the other 54h20 targets. Signed-off-by: Jonathan Nilsen <[email protected]>
jonathannilsen
force-pushed
the
iron-flashing-fix
branch
from
1493417 to
89816c6
Compare
|
|
Closing, will be invalidated by #91413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so the 54h20 'iron' variants have the same flashing behavior as the other 54h20 targets.