-
Notifications
You must be signed in to change notification settings - Fork 7.6k
llext: add dynamic heap allocation support #90871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llext: add dynamic heap allocation support #90871
Conversation
1a044f7
to
7f2e899
Compare
The change looks good, please add a test case so that it doesn't bitrot, should be fairly straightfoward |
2c8618f
to
b079b09
Compare
b079b09
to
a3ae350
Compare
@pillo79, I added init/uninit calls, please take a look. |
a3ae350
to
01aa754
Compare
e49e450
to
62a9127
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM, just a sanity check and some wording suggestions. Also, would you mind adding a note for CONFIG_LLEXT_HEAP_DYNAMIC
to this doc paragraph as well?
zephyr/doc/services/llext/config.rst
Lines 8 to 12 in 77c2c45
Heap size | |
---------- | |
The LLEXT subsystem needs a static heap to be allocated for extension related | |
data. The following option controls this allocation. |
62a9127
to
db565ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. Please use appropriate RST syntax, nothing else really.
Some applications require loading extensions into the memory which does not exist during the boot time and cannot be allocated statically. Make the application responsible for LLEXT heap allocation. Do not allocate LLEXT heap statically. Signed-off-by: Alex Ivanov <[email protected]>
db565ff
to
2c1995e
Compare
|
Some applications require loading extensions into the memory which does not exist during the boot time and cannot be allocated statically. Make the application responsible for LLEXT heap allocation. Do not allocate LLEXT heap statically.
This is created from and is a continuation of PR #90763.
TODO(@alexivanov-google): Comments to be addressed #90763 (comment)