cmake: add_llext_target: fix command expansion #90912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the invocation of the 'elfconvert' and 'slid_inject' commands in the `add_llext_target` function by ensuring that the arguments are expanded correctly before passing them to the shell. Signed-off-by: Luca Burelli <[email protected]>
|
github-actions
bot
added
area: Build System
size: XS
github-actions
bot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
pillo79
added
area: llext
kartben
approved these changes
Jun 6, 2025
tejlmand
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the invocation of the
elfconvertandslid_injectcommands in theadd_llext_targetfunction, ensuring that the arguments are expanded correctly before passing them to the shell.Fixes #90891.