drivers: led: AIROC LED driver #90914
Conversation
jlbwoods
force-pushed
the
pr_drivers_led_airoc
branch
from
0380b69 to
b63c192
Compare
LED driver utilizing the GPIO pins on top of the AIROC Wireless driver. Add AIROC LED driver to the DTS bindings in the LED section. Signed-off-by: John Lin <[email protected]>
jlbwoods
force-pushed
the
pr_drivers_led_airoc
branch
from
b63c192 to
9def04f
Compare
|
| default y | ||
| depends on DT_HAS_INFINEON_AIROC_LEDS_ENABLED | ||
| depends on NETWORKING | ||
| depends on WIFI |
There was a problem hiding this comment.
The CYW43439 should be a multi functional device (MFD), so it is strange to explicitly select WIFI here, but it can't be helped under the current circumstances.
The fact that the drivers are not neatly separated, so I worry about the exclusion of LED operation from WiFi operation, but will this be no problem?
There was a problem hiding this comment.
@soburi, can you clarify what you mean by MFD? I looked in the Zephyr documentation, and while 'mfd' shows up multiple times, its never defined.
There was a problem hiding this comment.
@ifyall
https://github.com/zephyrproject-rtos/zephyr/tree/main/drivers/mfd
MFD is a placeholder-like definition for a device that has multiple functions.
Because it is a placeholder, it does not have any functions aware of the user, but it may contain common definitions. Semaphores for mutual exclusion may also be placed here.
There was a problem hiding this comment.
OK, so a little bit more understanding (I guess). The CYW43439 does not have an LED. It provides Wi-Fi and BLE radio support to be controlled by a host MCU. Some modules the CYW43439 have been mounted on have additional hardware, including an LED.
So, I don't think this PR is correctly representing things. I believe @thedjnK is closer to reality.
If there is an MFD in here somewhere, would it then be the explicit modules (such as Murata's Type 1YN)?
| config LED_AIROC | ||
| bool "Infineon AIROC LED driver" |
There was a problem hiding this comment.
is this really an LED driver? Isn't it just a GPIO driver?
There was a problem hiding this comment.
I started out with GPIO driver, but I do not have detailed info regarding the GPIO specs on the AIROC chip. So, I created a LED driver that encapsulates that one particular GPIO pin (the Pico W LED light) on top of the AIROC WiFi driver.
There was a problem hiding this comment.
@jlbwoods, so isn't this a Pico specific driver then? There isn't an AIROC LED, so there shouldn't be an AIROC LED driver.
There was a problem hiding this comment.
That's right! So, what should I name the LED driver then? What about led_pico_w and LED_PICO_W since this particular setup only applies to Pico W.
There was a problem hiding this comment.
Created new PR using led_pico_w as the namespace: #91613
Please take a look again. Thank you!
Closing this PR.
|
Created new PR using led_pico_w as the namespace: #91613 |
LED driver utilizing the GPIO pins on top of the AIROC Wireless driver.
Notes: