drivers: dma: fix the WCH DMA transfer width #90924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzmichaelh
force-pushed
the
fix-dma-width
branch
2 times, most recently
from
b092e81 to
b52f49d
Compare
VynDragon
approved these changes
Jun 2, 2025
This adds `tests/drivers/dma/chan_blen_transfer` and `tests/drivers/dma/loop_transfer` as build tests to any manual Twister run. Signed-off-by: Michael Hope <[email protected]>
The driver treats the `source_data_size` and `dest_data_size` as a width in bits and converts 8 bits to 1, 16 bits to 2, and 32 bits to 3. This should be a width in bytes with 1 byte mapping to 0, 2 bytes to 1, and 4 bytes to 3. Note that this preserves the current behaviour of silently accepting invalid transfer bit widths. Signed-off-by: Michael Hope <[email protected]>
|
Rebased to fix the unrelated CI failure. |
VynDragon
approved these changes
Jun 9, 2025
|
EmilioCBen
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver treats the
source_data_sizeanddest_data_sizeas awidth in bits and converts 8 bits to 1, 16 bits to 2, and 32 bits to 3.
This should be a width in bytes with 1 byte mapping to 0, 2 bytes to
1, and 4 bytes to 3.
Note that this preserves the current behaviour of silently accepting
invalid transfer bit widths.