Skip to content

Bluetooth: BAP: SD: Fix missing clear of notify flag on reject #90943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

Thalley
Copy link
Collaborator

@Thalley Thalley commented Jun 2, 2025

For add and modify source, if the request was rejected by the application layer, the BASS_RECV_STATE_INTERNAL_FLAG_NOTIFY_PEND would be set but not unset.

Add unsetting the flag on reject.

Fixes #90655

For add and modify source, if the request was rejected by the
application layer, the BASS_RECV_STATE_INTERNAL_FLAG_NOTIFY_PEND
would be set but not unset.

Add unsetting the flag on reject.

Signed-off-by: Emil Gydesen <[email protected]>
Copy link

sonarqubecloud bot commented Jun 2, 2025

Copy link

@mefromac mefromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@pin-zephyr pin-zephyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kartben kartben merged commit 9844851 into zephyrproject-rtos:v3.7-branch Jun 4, 2025
31 of 32 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Bluetooth LE Audio Jun 4, 2025
@Thalley Thalley deleted the 3_7_sd_notify_fix branch June 4, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

LE-Audio: BAP scan delegator does not send further notifications after add source or modify source are rejected by application layer
5 participants