drivers: i2c: stm32: fix build error after timeout patch #91184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to PR zephyrproject-rtos#88631: fix missing variable declarations introduced in the STM32 I2C LL driver after adding timeouts to blocking loops. The missing declarations caused a build failure when interrupts were disabled (CONFIG_I2C_STM32_INTERRUPT=n). Fixes a regression introduced in zephyrproject-rtos#88631. Signed-off-by: Jean Nanchen <[email protected]>
github-actions
bot
requested review from
djiatsaf-st,
erwango,
etienne-lms,
FRASTM,
gautierg-st,
GeorgeCGV,
marwaiehm-st,
mathieuchopstm and
teburd
|
etienne-lms
approved these changes
Jun 6, 2025
|
Why wasn't this caught in CI? |
It seems to me that this is tested all the time with CONFIG_I2C_STM32_INTERRUPT=y |
erwango
approved these changes
Jun 6, 2025
|
@djiatsaf-st Can you check how to add one test config ensuring we're also building |
|
@erwango can this be backported to zephyr 3.7? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #88631: fix missing variable declarations introduced in the STM32 I2C LL driver after adding timeouts to blocking loops.
The missing declarations caused a build failure when interrupts were disabled (CONFIG_I2C_STM32_INTERRUPT=n).
Fixes a regression introduced in #88631.
Backport concerned (#90659, #90660, #90661)
@etienne-lms