Skip to content

boards: silabs: Support for efm32tg_stk3300 #91191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LukasWoodtli
Copy link

@LukasWoodtli LukasWoodtli commented Jun 6, 2025

Support for the Silabs EFM32TG-STK3300 Starter Kit.

Board features:

  • EFM32TG840F32 MCU with 32 kB flash and 4 kB RAM
  • Advanced Energy Monitoring
  • Real-time, accurate energy and power profiling
  • Light, LC and touch sensors
  • 8 x 20 LCD
  • SEGGER J-Link debugger

Signed-off-by: Lukas Woodtli [email protected]

@LukasWoodtli
Copy link
Author

Depends on PR for support for EFM32TG in hal_silabs.

Copy link

github-actions bot commented Jun 6, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_silabs zephyrproject-rtos/hal_silabs@190a144 (main) zephyrproject-rtos/hal_silabs#108 zephyrproject-rtos/hal_silabs#108/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_silabs DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jun 6, 2025
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split into multiple commits (at least 2) i.e. one for soc, one for board

CONFIG_UART_CONSOLE=y
CONFIG_SERIAL=y
CONFIG_GPIO=y
CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=32000000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get from dts property using function, and it should be set in soc Kconfig.defconfig file, not by a board

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the way other boards configure the clock cycles. It's also part of an example here: Board Porting Guide

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that documentation is very outdated and needs to be fixed, but this also needs to be fixed, this Kconfig needs to come from a dts value and in the soc Kconfig.defconfig file

Copy link
Author

@LukasWoodtli LukasWoodtli Jun 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have this changed in a different PR. It should be consistent for all board. And then the documentation should be updated accordingly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing new to be added with the old style, so if the old style remains in this PR then this PR will remain nacked

@LukasWoodtli LukasWoodtli force-pushed the efm32tg_stk3300 branch 2 times, most recently from 741d978 to a24e5c4 Compare June 10, 2025 20:09
Copy link
Collaborator

@jerome-pouiller jerome-pouiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhedberg
Copy link
Member

@LukasWoodtli is there a reason why you still want to keep this as a Draft PR?

* ARM Cortex-M3 processor
* Up to 32 kB Flash and 4 kB RAM memory
* Energy efficient and autonomous peripherals
* Ultra low power Energy Modes
* Fast wake-up

Signed-off-by: Lukas Woodtli <[email protected]>
Support for the Silabs EFM32TG-STK3300 Starter Kit.

Board features:

* EFM32TG840F32 MCU with 32 kB flash and 4 kB RAM
* Advanced Energy Monitoring
* Real-time, accurate energy and power profiling
* Light, LC and touch sensors
* 8 x 20 LCD
* SEGGER J-Link debugger

Signed-off-by: Lukas Woodtli <[email protected]>
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_silabs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants