-
Notifications
You must be signed in to change notification settings - Fork 7.6k
boards: silabs: Support for efm32tg_stk3300 #91191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
boards: silabs: Support for efm32tg_stk3300 #91191
Conversation
fa107f3
to
8a321f6
Compare
Depends on PR for support for EFM32TG in hal_silabs. |
2a3ccfc
to
fdb9a5f
Compare
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split into multiple commits (at least 2) i.e. one for soc, one for board
CONFIG_UART_CONSOLE=y | ||
CONFIG_SERIAL=y | ||
CONFIG_GPIO=y | ||
CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=32000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get from dts property using function, and it should be set in soc Kconfig.defconfig file, not by a board
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the way other boards configure the clock cycles. It's also part of an example here: Board Porting Guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that documentation is very outdated and needs to be fixed, but this also needs to be fixed, this Kconfig needs to come from a dts value and in the soc Kconfig.defconfig
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather have this changed in a different PR. It should be consistent for all board. And then the documentation should be updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing new to be added with the old style, so if the old style remains in this PR then this PR will remain nacked
741d978
to
a24e5c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@LukasWoodtli is there a reason why you still want to keep this as a Draft PR? |
30b3d36
to
1b57b83
Compare
* ARM Cortex-M3 processor * Up to 32 kB Flash and 4 kB RAM memory * Energy efficient and autonomous peripherals * Ultra low power Energy Modes * Fast wake-up Signed-off-by: Lukas Woodtli <[email protected]>
Support for the Silabs EFM32TG-STK3300 Starter Kit. Board features: * EFM32TG840F32 MCU with 32 kB flash and 4 kB RAM * Advanced Energy Monitoring * Real-time, accurate energy and power profiling * Light, LC and touch sensors * 8 x 20 LCD * SEGGER J-Link debugger Signed-off-by: Lukas Woodtli <[email protected]>
1b57b83
to
5baa9fd
Compare
|
Support for the Silabs EFM32TG-STK3300 Starter Kit.
Board features:
Signed-off-by: Lukas Woodtli [email protected]