-
Notifications
You must be signed in to change notification settings - Fork 7.6k
drivers: spi_ll_stm32: Add LOG to indicate that DMA cannot be enabled #91202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI compliance issues to be fixed
|
Fixed CI compliance issues |
Squash the 2nd commit |
drivers/spi/spi_ll_stm32.c
Outdated
LOG_ERR("SPI buffers are not in non-cacheable memory," | ||
" SPI DMA transfer is not supported"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOG_ERR("SPI buffers are not in non-cacheable memory," | |
" SPI DMA transfer is not supported"); | |
LOG_ERR("SPI buffers are not in non-cacheable memory, SPI DMA transfer is not supported"); |
Prefer trace message in a single line so that one can easier grep the message in the source file tree, see Linux kernel coding style directives:
However, never break user-visible strings such as printk messages because that breaks the ability to grep for them.
Maybe trace message can be shortened, e.g.:
LOG_ERR("SPI DMA transfers not supported on cached memory");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Accept the suggestion and use short messages.
Add LOG to indicate the reason why DMA cannot be enabled Signed-off-by: Wenbin Zhang <[email protected]>
a464080
|
Add LOG to indicate the reason why DMA cannot be enabled
When using the stm32h7 and W5500 network card driver, configuring CONFIG_SPI_STM32_DMA will silently fail.