drivers: sensor: fix condition in SQE acquisition check #91207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the logical operator (||, not |) in the condition that checks for successful acquisition of RTIO SQEs. Signed-off-by: Benjamin Cabé <[email protected]>
github-actions
bot
added
area: Sensors
github-actions
bot
requested review from
afontaine-invn,
asemjonovs,
avisconti,
gjabouley-invn,
jeppenodgaard,
MaureenHelm,
rbuisson-invn,
sriccardi-invn,
teburd,
tristan-google,
ubieda and
yperess
teburd
previously approved these changes
Jun 6, 2025
ubieda
previously approved these changes
Jun 6, 2025
ubieda
added
the
Trivial
Corrected the logical operator (||, not |) in the condition that checks for successful acquisition of RTIO SQEs. Signed-off-by: Benjamin Cabé <[email protected]>
kartben
changed the title
|
oops - there was another one :) Guess I maybe helped stopped the copy-paste contagion! |
teburd
approved these changes
Jun 6, 2025
|
|
hah, almost like we should make int rc = rtio_sqe_acquire_n(r, num, &sqes) or something telling, very telling |
ubieda
approved these changes
Jun 6, 2025
|
Looks like I'm the culprit of these. Thanks! |
MaureenHelm
approved these changes
Jun 9, 2025
yperess
approved these changes
Jun 9, 2025
dkalowsk
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the logical operator (||, not |) in the condition that checks for successful acquisition of RTIO SQEs.