Re: cvs: php-src(PHP_5_1) /ext/xmlreader php_xmlreader.c

From:	Rob Richards	Date:	Fri, 31 Mar 2006 11:09:23 +0000
Subject:	Re: cvs: php-src(PHP_5_1) /ext/xmlreader php_xmlreader.c
References:	1 2 3 4 5 6 7 8	Groups:	php.cvs
Request:	Send a blank email to [email protected] to get a copy of this message

>> As I see it, E_NOTICE should be thrown since accessing uninitialized
>> variable triggers E_NOTICE, why not XML attribute?
>> (yeah, massive BC break so no chance in hell I'd recommend
>> implementing it though)
>
> That's insane :-)
>
> Null is the way to go, the question was only when is the right time to
> make the change.

My (a bit late) input:
XMLReader is not DOM. As Pierre said it follows C# xmlTextReader behavior
and not DOM specs.

This is really a bug fix and should go in now. The behavior is changed
only slightly with minimal to no impact on existing scripts, but now will
at least produce correct behavior for those who need it.


   

Thread (10 messages)

• Marcus BoergerThu, 30 Mar 2006 17:37:50 +0000
  • Lukas Kahwe SmithThu, 30 Mar 2006 17:40:28 +0000Re: cvs: php-src(PHP_5_1) /ext/xmlreader php_xmlreader.c
    • PierreThu, 30 Mar 2006 17:42:11 +0000
      • Marcus BoergerThu, 30 Mar 2006 19:09:01 +0000
        • Hannes MagnussonThu, 30 Mar 2006 19:26:27 +0000
          • Marcus BoergerThu, 30 Mar 2006 21:02:31 +0000
            • Hannes MagnussonThu, 30 Mar 2006 23:22:02 +0000
              • PierreThu, 30 Mar 2006 23:26:38 +0000
                • Rob RichardsFri, 31 Mar 2006 11:09:23 +0000
    • Ilia AlshanetskyThu, 30 Mar 2006 17:46:34 +0000