Follow up of DateTimeException RFC

From: Date: Thu, 13 Jun 2024 06:55:31 +0000
Subject: Follow up of DateTimeException RFC
Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
Hi,

There was an RFC about more appropriate date exceptions
https://wiki.php.net/rfc/datetime-exceptions
implemented in
https://github.com/php/php-src/commit/66a1a911f1d6cd4b89c0bb5577fa77f1d6a2cb96

Looking at PHP example, it updated method return types like
- Datetime::modify
- DatetimeImmutable::modify
- DateInterval::createFromDateString

https://3v4l.org/iSPL9

These methods doesn't seem to return false anymore, but the PHP stub wasn't
updated so the reflection class still consider false as a valid return type
https://3v4l.org/IZXbp.

Is there still case where such method can return FALSE or should we update
the signature of these methods (and maybe some others) ?

Thanks.


Thread (1 message)

  • Vincent Langlet
« previous php.internals (#123592) next »