Re: Re: [RFC] [Vote] #[\Deprecated] attribute
Hi
On 6/24/24 17:06, Nicolas Grekas wrote:
Since the vote passed, we're discussing how we might use the attribute in
Symfony.
2 things on the topic:
1/ We're wondering about using it at the class level despite the missing
Attribute::TARGET_CLASS. ReflectionAttribute does allow reading attributes
without checking these flags and we might leverage this capability to make
our DebugClassLoader able to inspect those at the class level.
Would you consider adding Attribute::TARGET_CLASS in 8.4 already? It would
just make sense to me. We don't need the engine to do anything about
deprecated classes ever since all we need in userland is a class-loader
that checks for the attribute. Keeping the engine simpler and empowering
userland with maximum flexiblity FTW. I'm up for a quick RFC if the
consensus is this needs one.
I didn't consult with Benjamin and thus I'm not speaking for him, but for me this definitely requires an additional RFC:
A main point of our RFC was to make the *existing* deprecation functionality available to userland. There is no existing deprecation functionality for classes (e.g. no ReflectionClass::isDeprecated()) and thus supporting the attribute on classes was out of scope / left for future scope.
Personally I would against such an RFC, because it adds to the inconsistency of the language by not emitting a deprecation warning.
2/ About the "since" parameter, we're going to standardize around a
package+version string, e.g.
#[Deprecated(since: "symfony/yaml v7.2"]
I'm sharing this hoping this can spread outside of Symfony's boundary
because I think this would be a very useful practice that'd allow building
nice reporting tools.
You might be interested in this thread on the implementation PR then: https://github.com/php/php-src/pull/11293#discussion_r1647339607
Best regards
Tim Düsterhus
Thread (21 messages)