Re: [RFC] Property Hook improvements
Hi
On 7/1/24 19:02, Larry Garfield wrote:
I'd say we expect these to be uncontroversial, but this is PHP. :-) So I will instead just note that it's a short RFC and open the discussion accordingly.
Big fan of the performance improvement, given that I convinced Ilija to look into that once more. Really happy with what he found there.
For the second part about supporting readonly: I don't want to rush this in the last few weeks before feature freeze, especially since the word 'investigating' appears in the RFC text. Given that readonly is currently entirely unsupported, this could very well be added with PHP 8.5, allowing folks to really think about the implications and how it interacts with stuff. That's a "no" from my side.
Best regards
Tim Düsterhus
PS: Small typo: '$this-dbApi->loadCategory($this->categoryId);', '>' missing there after 'this-'.
Thread (17 messages)