Re: ext/gd adding imagecompare
Hi David,
> Hi,
>
> I plan to add imagecompare to the gd extension. No problem so far however a little discussion
> of the returned value
>
> https://github.com/php/php-src/pull/14877#issuecomment-2217686123
>
> I personally see a value of a bitmask rather than just boolean which is not harder to handle
> than imagetypes.
>
> Let me know your thoughts.
>
> Cheers.
If the return value is bool, does this mean that it will be true if the comparison targets are
exactly the same, and false if there is even one difference? In other words, will we no longer be
able to see where the differences were?
Regards,
Saki
Thread (10 messages)