Re: [RFC] Asymmetric Visibility, v2

From: Date: Mon, 22 Jul 2024 16:18:23 +0000
Subject: Re: [RFC] Asymmetric Visibility, v2
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
On Sun, Jul 21, 2024, at 2:45 PM, Tim Düsterhus wrote:
> Hi
>
> On 7/20/24 03:14, Larry Garfield wrote:
>> We've made one change since we last discussed it:  Specifically, Ilija realized that
>> __set's behavior is already inconsistent, so supporting it for aviz properties with invisible
>> set would make it even more inconsistent, not less.  For that reason, we've changed the __set
>> behavior such that a non-readonly aviz property will not trigger __set.  Further details are in the
>> RFC, but in short, all of the use cases for that behavior now have better alternatives, such as
>> property types, hooks, and aviz itself.  So there's really no point to falling back to __set in
>> edge cases.
>> 
>> https://wiki.php.net/rfc/asymmetric-visibility-v2#interaction_with_set_and_unset
>> 
>> Baring any new developments, we plan to start the vote early next week.
>
> I find it unfortunate that this RFC received a non-trivial change on a 
> Saturday after the discussion has been idle for more than a month 
> together with the announcement that the vote will begin shortly after 
> the weekend. Folks should be given sufficient time to react to the 
> newest developments. Personally I plan to give this RFC another read, 
> because I already forgot the details after a month of not looking at it, 
> but I'm not sure if I'll manage today.
>
> For now:
>
> Is there any implementation of this RFC? The RFC text only references 
> the https://github.com/php/php-src/pull/9257 PR
> hasn't been updated 
> since December 2022.
>
> Best regards
> Tim Düsterhus

Oof, sorry, I thought Ilija had updated the link already.  It is now updated, and the PR is here:

https://github.com/php/php-src/pull/15063

Since the PR wasn't easily available until now, we're going to push the vote start back to
this coming Friday.

--Larry Garfield


Thread (57 messages)

« previous php.internals (#124549) next »