Re: [RFC] Static property asymmetric visibility

From: Date: Tue, 07 Jan 2025 18:38:59 +0000
Subject: Re: [RFC] Static property asymmetric visibility
References: 1 2  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
On 04/01/2025 00:14, Larry Garfield wrote:
> On Mon, Nov 25, 2024, at 10:52 AM, Larry Garfield wrote:
>> Static property asymmetric visibility was left out of the original RFC, 
>> because it seemed like it would be hard and of little use.  Turns out, 
>> Ilija found a way to make it easy.  (Ilija is smart.)  So here's a 
>> small RFC to add aviz to static properties, because we can't think of a 
>> reason to NOT do so.
>>
>> https://wiki.php.net/rfc/static-aviz
> 
> Heads up: Absent any other feedback, I'm going to call the vote on this RFC early next
> week.
> 
> --Larry Garfield

Hi

I'm not sure how I feel about this.
The current implementation actually uses a workaround because otherwise it interferes with cache
slot merging.
This creates duplicated code in the VM handlers. Although the complication is small, it still is
one. And the complication may be duplicated in the future in the JIT.
Workarounds/complications can be fine if having the feature is justifiable, but you said yourself
that it seems of little use and the RFC text says it's just for completeness.
So honestly, I'm conflicted and leaning towards voting "no".

Kind regards
Niels


Thread (11 messages)

« previous php.internals (#126203) next »