Re: [Vote] Pipe operator
On Wed, May 14, 2025, at 10:36 PM, Theodore Brown wrote:
> On Wed, May 14, 2025 at 09:08 Larry Garfield wrote:
>
>> On Tue, May 13, 2025, at 5:55 PM, Ilija Tovilo wrote:
>>> On Tue, May 13, 2025 at 3:58 AM Larry Garfield <[email protected]> wrote:
>>>>
>>>> I hereby open the vote on the Pipe operator RFC:
>>>>
>>>> https://wiki.php.net/rfc/pipe-operator-v3
>>>
>>> It looks like the example under "Rejected Features" is wrong.
>>>
>>> // With Elixir style
>>> $foo
>>> |> bar(...)
>>>
>>> should be
>>>
>>> $foo
>>> |> bar()
>>>
>>> Also a nit: The RFC says "There was discussion off-list of
>>> “auto-partialling” functions after a pipe", but this idea was since
>>> discussed on-list as well.
>>>
>>> Ilija
>>
>> Hm, good catch. Normally you're not supposed to edit an RFC in voting,
>> but as this is a typo fix in a Rejected Features section (ie, it has
>> zero impact on the thing being voted on), I think it's probably OK to fix.
>>
>> I'll give a day or so for someone to object that it still shouldn't be allowed,
>> and if no one does then I'll make those edits.
>>
>> --Larry Garfield
>
> I think it's fine to fix typos, misspellings, and grammar mistakes
> which don't affect what's being voted on.
>
> While you're at it, please also fix the match() example, which should
> not contain case keywords.
>
> Theodore
I have made the above corrections. No substantive changes were made to the RFC.
For verification, here's the diff: https://wiki.php.net/rfc/pipe-operator-v3?do=diff&rev2%5B0%5D=1747101303&rev2%5B1%5D=1747316653&difftype=sidebyside
--Larry Garfield
Thread (8 messages)