Re: [PATCH] unicode_semantics "off" evaluates to true

From: Date: Mon, 13 Feb 2006 17:26:13 +0000
Subject: Re: [PATCH] unicode_semantics "off" evaluates to true
References: 1 2  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message 
I don't think it's right to call it unicode_enabled(). Unicode is always accessible, it's just that certain language semantics don't use it when unicode_semantics is off. So I'd call the function unicode_semantics() or unicode_default().

-Andrei

On Feb 13, 2006, at 1:20 AM, Marcus Boerger wrote:


Hello Brion,

  i applied your fix which was correct. I however also added a function to
check for unicode mode "bool unicode_enabled()" which returns true if
unicode_semantics is set true.

best regards
marcus

Monday, February 13, 2006, 10:07:58 AM, you wrote:


Index: Zend/zend.c
===================================================================
RCS file: /repository/ZendEngine2/zend.c,v
retrieving revision 1.333
diff -u -r1.333 zend.c

--- Zend/zend.c 8 Feb 2006 18:52:13 -0000       1.333

+++ Zend/zend.c	13 Feb 2006 08:53:35 -0000
@@ -197,7 +197,7 @@

        STD_ZEND_INI_BOOLEAN("zend.ze1_compatibility_mode",     "0",
ZEND_INI_ALL,           OnUpdateBool,   ze1_compatibility_mode,

zend_executor_globals,  executor_globals)


        /* Unicode .ini entries */
-       STD_ZEND_INI_ENTRY("unicode_semantics", "off", ZEND_INI_SYSTEM,

OnUpdateBool, unicode, zend_unicode_globals, unicode_globals)

+       STD_ZEND_INI_BOOLEAN("unicode_semantics", "0", ZEND_INI_SYSTEM,

OnUpdateBool, unicode, zend_unicode_globals, unicode_globals)

        STD_ZEND_INI_ENTRY("unicode.fallback_encoding", NULL,

ZEND_INI_ALL, OnUpdateEncoding,   fallback_encoding_conv,
zend_unicode_globals, unicode_globals)

        STD_ZEND_INI_ENTRY("unicode.runtime_encoding",  NULL,

ZEND_INI_ALL, OnUpdateEncoding,   runtime_encoding_conv,
zend_unicode_globals, unicode_globals)

        STD_ZEND_INI_ENTRY("unicode.script_encoding",  NULL,

ZEND_INI_ALL, OnUpdateEncoding,   script_encoding_conv,
zend_unicode_globals, unicode_globals)





Best regards,
 Marcus

-- PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Thread (5 messages)

« previous php.internals (#21863) next »