Re: Adieu a la magie (remove magic_quotes)
On Tue, 7 Mar 2006 16:22:08 +0100
[email protected] (Pierre) wrote:
> On 3/7/06, Pierre <[email protected]> wrote:
> >
> > On 3/7/06, Zeev Suraski <[email protected]> wrote:
> >
> > > The point is that breakage is aggregated, not binary. The more
> > > stuff we break, the more difficult it is to port, and frankly,
> > > it's quite likely that a non OO app could migrate fairly cleanly
> > > even to PHP 6 with unicode disabled (perhaps with minor
> > > fixes). get_magic_quotes_gpc() is designed for apps to do
> > > something differently depending on the value of
> > > magic_quotes_gpc. It's fine that it's always off in PHP 6, but
> > > there's no reason not to keep this function (to always return
> > > false) so that you don't have to fix God knows how many lines of
> > > code to remove it.
> >
> > Fair enough, as I said in my last post in the magic_quotes thread,
> > it is easy to keep this function. I will modify the patch to keep
> > the related functions (returning always false). Is is ok?
>
> The patch is now updated (same link). The functions are restored but
> deprecated using the new ZEND_DEP_* macros.
>
> set_magic_quotes_runtime raise a E_CORE_ERROR as described in the PDM.
> The other always return false.
>
> No more objection?
Done, as Zeev said, the functions are kept and return false, except for
set_magic_quotes_runtime which raises a core error. They are declared
using the depracated flag.
--Pierre
Thread (6 messages)