Re: Re: PHP 5.1.3RC2 Released

From: Date: Sun, 02 Apr 2006 17:59:52 +0000
Subject: Re: Re: PHP 5.1.3RC2 Released
References: 1 2  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
The i variable inside insertionsort() is used by the swap() macro and is actually needed. The other two issues are indeed valid and patches to fix them have just been applied to CVS, thanks for pointing them out.

Ilia

Ron Korving wrote:
Nice to see RC2 :) I noticed that few of my earlier observations have not been addressed though, and these are minor cleanups, but they are cleanups: 1) An unused variable 'i' in insertionsort() in main/mergesort.c 2) CONTEXT_TYPE_IMAGE_GIF in main/logos.h is defined as "Content-Type: image/gif" with 2 spaces between "Content-Type" and "image/gif" 3) In sapi/apache/mod_php5.c in the function php_apache_log_message() there are 2 fprintf() calls which could just as easily be done with 1:
    fprintf(stderr, "%s\n", message);
instead of:
    fprintf(stderr, "%s", message);
    fprintf(stderr, "\n");
I can't 100% guarantee that this is all safe, but it all seems(!) perfectly safe to me. Regards, Ron "Ilia Alshanetsky" <[email protected]> wrote in message news:[email protected]...
PHP 5.1.3RC2 has just been released, about a week late, but better late then never ;-). Please test this RC as much as possible, if it proves to be stable, this release will be published as final next week Thursday. The source packages can be found here: http://downloads.php.net/ilia/php-5.1.3RC2.tar.bz2 MD5: 8ad7bddc9a3b4dbcd2ecb1d6f5446970 http://downloads.php.net/ilia/php-5.1.3RC2.tar.gz MD5: 1e66780413580bc4a0742fa302735c99 Win32 binaries will be available for download shortly. Ilia 5.1 Release Master


Thread (7 messages)

« previous php.internals (#22646) next »