Re: [VOTE]strn(case)cmp supporting a negative length as its third paramter

From: Date: Sun, 14 Aug 2011 11:24:37 +0000
Subject: Re: [VOTE]strn(case)cmp supporting a negative length as its third paramter
References: 1 2 3 4 5  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
On Sat, 13 Aug 2011, Laruence wrote:

> Dear all:
>     I am going to close strn(case)cmp supporting negative length vote,
> since it has been calling for vote near two weeks, and no new feedback
> .
> 
>     the Voting result is:
>      Support :  6  felipe pajoye pierrick gwynne tyrael laruence
>      Decline :  3  iliaa rasmus salathe
> 
>     it wins 2/3 vote,   so I think this supposed to mean that accept,  right?

I voted against too. Also, you started the vote with not even a week 
between RFC announcement and call for voting, so I guess that makes this 
invalid?


Just looked over the RFC, and this whole example is weird:

<?php
var_dump(strncmp("prefix_num", "num", -10));
?>
  
Why does it even find the substring as you can't do "-10" from the end? 
If the number is too high, it should give you a warning.

cheers,
Derick

-- 
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug


Thread (33 messages)

« previous php.internals (#54574) next »