SKIIP of FAIL for tests depending on external bugs

From: Date: Mon, 05 Sep 2011 13:34:39 +0000
Subject: SKIIP of FAIL for tests depending on external bugs
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message 

Am 05.09.2011 15:28, schrieb Andrey Hristov:

On 09/05/2011 03:19 PM, Ulf Wendel wrote:

... always use the latest and greatest. Libmysql bug, exact version
range is not known to me. Feel free to change the test to be skipped
during SKIPIF, for example, like this:

require(connect.inc)
if (!IS_MYSQLND && libmysql_version > ... && libmysql_version < ...)
die(skip libmysql bug)

At the first look, I can't find a related bug report at bugs.php.net.
Looks like few people compare PS and non-PS metadata for EXPLAIN in
their application.


this is exactly what I mean. If there was a bug in a previous version
and you try to use it, what do you want to see? SKIP or FAIL? I vote


Andrey,

you are changing topic from MySQL something test failure to test writing in general. IMHO you are raising a general question worth a dedicated discussion thread, something like:

"If a test depends on external entity, which has a bug, shall the test FAIL or be SKIPPed?"

I'd appreciate if this is discussed independently of the example of a mysqli test failure discussed in the light of the upcoming PHP 5.4 beta.

Ulf

Thread (23 messages)

« previous php.internals (#55223) next »