Re: Re: [PHP-DEV] Fixing string offsets of strings.

From: Date: Tue, 06 Dec 2011 16:41:44 +0000
Subject: Re: Re: [PHP-DEV] Fixing string offsets of strings.
References: 1 2  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
Hi Alan:

> b) fix isset, and return first character
> ISSET: return false (no warning)
> READ: warning + return first character (similar to current behavior
> except dereferenced strings)
> 
> c) fix isset, and return empty strings
> ISSET: return false (no warning)
> READ: warning + return empty string  

While "c" is cleaner, "b" is less of a change, so it seems that's the
best way to go.  What do other people think?

FYI, when I applied your existing patch to trunk, the following build
error comes up:

	/php/php/php-src/trunk/Zend/zend_execute.c: In function
	‘zend_fetch_dimension_address’:
	/php/php/php-src/trunk/Zend/zend_execute.c:1164: error: ‘NOTICE’
	undeclared (first use in this function)
	/php/php/php-src/trunk/Zend/zend_execute.c:1164: error: (Each
	undeclared identifier is reported only once
	/php/php/php-src/trunk/Zend/zend_execute.c:1164: error: for each
	function it appears in.)

Thanks,

--Dan

-- 
 T H E   A N A L Y S I S   A N D   S O L U T I O N S   C O M P A N Y
            data intensive web and database programming
                http://www.AnalysisAndSolutions.com/
 4015 7th Ave #4, Brooklyn NY 11232  v: 718-854-0335 f: 718-854-0409


Thread (29 messages)

« previous php.internals (#56814) next »