Re: hash / tiger regression in PHP 5.4.0
Le 08/03/2012 09:03, Michael Wallner a écrit :
> On Mon, 05 Mar 2012 17:52:52 +0100, Remi Collet wrote:
>
>>
>> Using a simple C program (linked against libmash)
>>
>> Hash: fdb9019a79c33a95677e2097abae91eb0de00b3054bb5c39
>>
>> So the result from php <= 5.3.10 seems the right one.
>
> Sorry for the delay, but I already explained the issue in
> the bug report: https://bugs.php.net/bug.php?id=61291
Thanks, for the explanation.
I raised this issue, because of 2 failing tests.
Another test (because Interoperability seems important)
$ perl -e 'use Digest::Tiger;my $hexhash =
Digest::Tiger::hexhash("");print $hexhash."\n";'
3293AC630C13F0245F92BBB1766E16167A4E58492DDE73F3
$ php -r 'echo hash("tiger192,3", "")."\n";'
3293ac630c13f0245f92bbb1766e16167a4e58492dde73f3
So, this seems ok.
But mhash_001.phpt and mhash_003.phpt should not fail
(if we want a great PHP with 0 test failed).
As this tests seems to be old ones from old mhash extension,
they probably should be tagged as "expected failed" with a message such
as "Compatibility break with php < 5.4.0"
Best regards.
>
> Thanks anyway,
> Mike
>
>
Thread (10 messages)