Re: [RFC] Add hash_pbkdf2 function
On 19 Jun, 2012, at 2:24 PM, Adam Jon Richardson <[email protected]> wrote:
> On Mon, Jun 18, 2012 at 7:14 PM, Anthony Ferrara <[email protected]> wrote:
>> https://wiki.php.net/rfc/hash_pbkdf2
>>
>> What are your thoughts?
>
> That's very nice, indeed.
>
> One thing I'm wondering about is whether the last parameter could be
> changed from:
> raw_output = false
>
> To something like:
> output = "hex" (also allowing output = "raw", output = "base64")
>
That wouldn't be consistent with the rest of the hash_ family though :)
> Just thinking that most of the time I'd prefer storing the hashed
> passwords as base64-encoded strings just because it's more compact,
> but this isn't a big deal, just a thought.
>
> Really nice work!
>
> Adam
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
Thread (15 messages)