Re: [proposal + pull request] Replace logo GUIDs with data URIs

From: Date: Sat, 14 Jul 2012 21:48:57 +0000
Subject: Re: [proposal + pull request] Replace logo GUIDs with data URIs
References: 1 2  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message 
Hi!

> And I actually know of websites using the functions to display the logo..
> Is there some way we could provide a BC function for it somehow?
> Maybe rather then removing the functions, make then return the data uris?

Having the functions to get the images sounds like a good idea, some
sites may want to use them to display the logos. However, I don't think
we should use the same function, as then deciding what the function
actually does is complicated. I'd rather prefer doing something like:

if(function_exists('php_logo_guid')) {
  $url = "/index.php?=".php_logo_guid();
} else if(function_exists('php_logo_url')) {
  $url = php_logo_url();
}
if(!empty($url))
echo "<img src=\"$url\" alt=\"php logo\">";

it's clear what each function gives me then.

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

Thread (8 messages)

« previous php.internals (#61238) next »